Enable nullable for enum localize classes & Bump version to 0.0.5 #39
+12
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables nullable reference types for enum localize classes and bumps the package version to 0.0.5. The changes address build warnings that occur when nullable reference types are used with INotifyPropertyChanged from a previous PR (#38).
- Enable nullable reference types in generated enum localize classes
- Update version numbers from 0.0.4 to 0.0.5 across all version properties
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Flow.Launcher.Localization.csproj | Version bump to 0.0.5 for package release |
| EnumSourceGenerator.cs | Enable nullable context and add nullable annotations to string properties |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Flow.Launcher.Localization.SourceGenerators/Localize/EnumSourceGenerator.cs
Show resolved
Hide resolved
Flow.Launcher.Localization.SourceGenerators/Localize/EnumSourceGenerator.cs
Show resolved
Hide resolved
Flow.Launcher.Localization.SourceGenerators/Localize/EnumSourceGenerator.cs
Show resolved
Hide resolved
|
Not quite familiar with this part. Is it good to go? |
I think so. It will not change any runtime behaviour and is just used to resolve compile warnings. |
VictoriousRaptor
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable nullable for enum localize classes
Follow on with #38.
#38 introduces
INotifyPropertyChangedwhich contains nullable type?usage. So we should enable nullable for enum localize classes. Or it will lead to VS build warning:Bump version to v0.0.5
Version bump for test release.